fix: improve error handling #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
Contributor
Contributor
Author
|
Done! 👍 |
bahmutov
reviewed
Apr 1, 2020
Contributor
|
🎉 This PR is included in version 1.3.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify plugins can choose to notify errors with either:
failPlugin(): stops the plugin but not the whole buildfailBuild(): stops the whole buildThis PR uses
failPlugin()for error with the Cypress setup itself, andfailBuild()when the Cypress tests fail (including the ping).utils.buildis guaranteed to exist, so this PR also removes that additional check. This is turns allows removing few dependencies.